Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rambox: fix meta #77782

Merged
merged 1 commit into from Jan 15, 2020
Merged

rambox: fix meta #77782

merged 1 commit into from Jan 15, 2020

Conversation

@gnidorah
Copy link
Member

gnidorah commented Jan 15, 2020

Motivation for this change

Thanks @Infinisil

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Infinisil Infinisil merged commit c1151c1 into NixOS:master Jan 15, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Checking original out paths
Details
@gnidorah gnidorah deleted the gnidorah:rambox branch Jan 15, 2020
@gnidorah

This comment has been minimized.

Copy link
Member Author

gnidorah commented Jan 15, 2020

@Infinisil Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.