Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnunet: 0.12.1 -> 0.12.2 #77785

Open
wants to merge 1 commit into
base: master
from
Open

gnunet: 0.12.1 -> 0.12.2 #77785

wants to merge 1 commit into from

Conversation

@pstn
Copy link
Contributor

pstn commented Jan 15, 2020

Motivation for this change

Quick bump for the minor release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested a review from vrthra Jan 15, 2020
@pstn pstn mentioned this pull request Jan 16, 2020
6 of 10 tasks complete
@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Jan 16, 2020

Just checking — are you happy with the author name/email of the commit? Asking because it doesn’t seem to be associated with your GitHub account.

@pstn pstn force-pushed the pstn:gnunet-12.2 branch from 8a0e339 to de82c5c Jan 20, 2020
@pstn

This comment has been minimized.

Copy link
Contributor Author

pstn commented Jan 20, 2020

Ah, thank you for mentioning it.

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Jan 21, 2020

@pstn

This comment has been minimized.

Copy link
Contributor Author

pstn commented Jan 22, 2020

Aha! The Email in the commit needs to match a validated one in the profile. I guess that's smart for security reasons. Since I don't publish my sign-up emails, I didn't use that in the commit, but I could add that public emails to my profile and now there are pretty pictures in the commit. Thanks again!

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Jan 23, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.