Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwan: indicate jemalloc should be used, or it won't be #77844

Conversation

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Jan 16, 2020

Motivation for this change

Since we are kind enough to provide it a custom allocator
(you know how many packages wish they were as lucky?!)
kindly encourage they play together so as not to be rude.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
(cherry picked from commit d45a92f)
@dtzWill
Copy link
Contributor Author

@dtzWill dtzWill commented Feb 13, 2020

Closing in favor of #79970 .

@dtzWill dtzWill closed this Feb 13, 2020
@dtzWill dtzWill deleted the dtzWill:fix/lwan-jemalloc-is-here-on-your-behalf-dont-ignore-it-please branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.