Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp: git rev 2c88e8 (2019-06-09) -> 0.6.1 #77975

Merged
merged 1 commit into from Feb 12, 2020
Merged

Conversation

@sjmackenzie
Copy link
Contributor

@sjmackenzie sjmackenzie commented Jan 18, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

src = fetchFromGitHub {
owner = "jmacdonald";
repo = pname;
rev = "2c88e82a88ada8a5fd2620ef225192395a4533a2";
sha256 = "0ha1xiabq31s687gkrnszf3zc7b3sfdl79iyg5ygbc49mzvarp8c";
rev = "e49c71d85a17a8d17423c1ab73758a0f84bcb89a";

This comment has been minimized.

@sbourdeauducq

sbourdeauducq Jan 18, 2020
Contributor

rev = version?

This comment has been minimized.

@sjmackenzie

sjmackenzie Jan 18, 2020
Author Contributor

okay, tested locally and it builds with rev = version. where version = "0.6.1";, change request pushed.

This comment has been minimized.

@sbourdeauducq

sbourdeauducq Jan 18, 2020
Contributor

I believe "0.6.1" and not "v0.6.1" is the right version string anyway; this is actually one of the rare semi-niche details of Nix that is well documented :)

This comment has been minimized.

@sjmackenzie

sjmackenzie Jan 18, 2020
Author Contributor

Ah you mean in the commit message - hmm I really wonder if that even matters. Is it worth kicking off all the CI resources just to drop a character in the commit message?

This comment has been minimized.

@sjmackenzie

sjmackenzie Jan 22, 2020
Author Contributor

yo sebastien, can you please check the review thingy.

@sjmackenzie sjmackenzie force-pushed the sjmackenzie:amp branch from f6de1b6 to 521ac53 Jan 18, 2020
@ofborg ofborg bot requested a review from sbourdeauducq Jan 18, 2020
@sjmackenzie sjmackenzie requested a review from joachifm Jan 18, 2020
@sjmackenzie sjmackenzie changed the title amp: git rev 2c88e8 (2019-06-09) -> v0.6.1 amp: git rev 2c88e8 (2019-06-09) -> 0.6.1 Jan 18, 2020
@joachifm joachifm removed their request for review Jan 20, 2020
@sjmackenzie
Copy link
Contributor Author

@sjmackenzie sjmackenzie commented Feb 11, 2020

could someone be a dear and merge this please? cc @qknight @adisbladis

@adisbladis adisbladis merged commit 8a25300 into NixOS:master Feb 12, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
amp on aarch64-linux Success
Details
amp on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@sjmackenzie sjmackenzie deleted the sjmackenzie:amp branch Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.