Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc: 8.8.2-rc1 -> 8.8.2 #77986

Merged
merged 1 commit into from Jan 19, 2020
Merged

ghc: 8.8.2-rc1 -> 8.8.2 #77986

merged 1 commit into from Jan 19, 2020

Conversation

@ggreif
Copy link
Contributor

ggreif commented Jan 18, 2020

Motivation for this change

ghc-8.8.2 is out, the rc is obsolete now.

https://www.haskell.org/ghc/blog/20200116-ghc-8.8.2-released.html

Things done

Rebuild from the fresh tarball.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS (High Sierra)
    • other Linux distributions (by OfBorg?)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ggreif ggreif force-pushed the ggreif:patch-2 branch 2 times, most recently from cd22c01 to b6d286f Jan 18, 2020
@ggreif ggreif marked this pull request as ready for review Jan 18, 2020
@ggreif ggreif requested review from basvandijk and cdepillabout as code owners Jan 18, 2020
@ggreif ggreif force-pushed the ggreif:patch-2 branch from b6d286f to 50e0a35 Jan 18, 2020
Copy link
Contributor Author

ggreif left a comment

Thanks for the guidance!

@ggreif ggreif force-pushed the ggreif:patch-2 branch from 50e0a35 to 42fd1d0 Jan 18, 2020
@peti peti merged commit a097fa6 into NixOS:master Jan 19, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
ghc on aarch64-linux Success
Details
ghc on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ggreif ggreif deleted the ggreif:patch-2 branch Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.