Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailscale: init at 0.94-236. #78008

Closed
wants to merge 6 commits into from
Closed

tailscale: init at 0.94-236. #78008

wants to merge 6 commits into from

Conversation

@danderson
Copy link
Contributor

@danderson danderson commented Jan 19, 2020

Motivation for this change

Tailscale is a mesh VPN service that I want to run on my NixOS machines. This change adds the package derivation. A future change will add a corresponding NixOS module (or I can add it to this change if you prefer).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [n/a] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [n/a] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [n/a] Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@danderson
Copy link
Contributor Author

@danderson danderson commented Jan 19, 2020

@danderson
Copy link
Contributor Author

@danderson danderson commented Jan 19, 2020

Right now the package can't start in nixos, due to missing runtime dependencies. Fixing that tomorrow, but in the meantime it should still be usable from plain nix.

danderson added 3 commits Jan 19, 2020
This is used by the nixos module as the default ACL.
@tazjin
Copy link
Member

@tazjin tazjin commented Feb 10, 2020

@danderson Since the client is now open-sourced (congrats, btw!), would it make sense to drop this PR in favour of one that builds the client instead?

FWIW, I've packaged it in my own repository over here but think it probably makes sense for you to be the maintainer here.

@danderson
Copy link
Contributor Author

@danderson danderson commented Feb 10, 2020

Heh, you're quick on the mark :)

Yes, it makes complete sense to drop this in favor of an OSS derivation.

In fact, it makes even more sense for me to wait on a nix pkg until we're replaced relaynode (old, prototype code that we currently ship for linux) with tailscaled (shiny, new, more featured code that we don't ship yet). I'll close this and make a new PR when tailscaled is ready to ship :)

@danderson danderson closed this Feb 10, 2020
@danderson
Copy link
Contributor Author

@danderson danderson commented Feb 10, 2020

Oh, you already built the OSS version as tailscaled!

Hmm. I think I'd prefer to delay "official" Nix/NixOS support by a couple of days, until I have a few more changes ready in tailscaled (to avoid having to do data migrations and other nonsense later on).

@tazjin
Copy link
Member

@tazjin tazjin commented Feb 10, 2020

Totally reasonable! I'm just excited to be able to play with it now, but I did end up adding the relaynode subpackage to get things to work.

Didn't you also already make a NixOS module? I thought I saw that somewhere 🤔

@danderson
Copy link
Contributor Author

@danderson danderson commented Feb 10, 2020

I started making a nixos submodule in another branch of my nixpkgs fork, but it was dependent on this PR. I don't think there's anything left to clean up on the nixpkgs side.

If you want the commit for yourself, it's at danderson@46aa331 . No promises that it works, I don't think I got as far as "does this even run" :)

@martinbaillie
Copy link
Contributor

@martinbaillie martinbaillie commented Mar 8, 2020

Glad I found this as I was about to package up a Tailscale derivation myself! Do we think the Tailscale codebase at a stage now where a PR makes sense? (happy to help)

@danderson
Copy link
Contributor Author

@danderson danderson commented Mar 8, 2020

I think so. I've been meaning to get to it, but I keep getting distracted with other things :). I'll file an issue in the tailscale repo and cc you on it, there's a little bit of complexity around version stamps that we need to figure out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.