Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minidlna: provide configuration option for announce interval #78024

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@wamserma
Copy link
Contributor

@wamserma wamserma commented Jan 19, 2020

Signed-off-by: Markus S. Wamser github-dev@mail2013.wamser.eu

Motivation for this change

Provide a configuration option to set announce interval in miniDLNA config file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Signed-off-by: Markus S. Wamser <github-dev@mail2013.wamser.eu>
@obadz
Copy link
Contributor

@obadz obadz commented Jan 28, 2020

Does that help with VLC as a client? I ended up giving up on DLNA and switching to FTP because VLC couldn't find MiniDLNA.

@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Jan 28, 2020

@obadz It did help me with Skifta to see the Server soon after firing up the app. I guess a shorter announce-interval also helps with other Clients.
I kindly ask for merging this soon, as has already been done for the backport (#78025).

edit: Just tested with VLC on Ubuntu 18.04 as client and miniDLNA on NixOS stable as server, announce interval set to 60 seconds. The server was quickly detected after clicking the Universal Plug'n'Pray entry in the playlist window.

Remeber you have to explicitly open TCP port 8200 for miniDLNA.

@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Feb 7, 2020

cc @Infinisil backport of this (#78025) has already been merged

@wamserma wamserma requested review from Infinisil and jonringer Feb 7, 2020
@Infinisil Infinisil merged commit 6169eef into NixOS:master Feb 10, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
minidlna on aarch64-linux Success
Details
minidlna on x86_64-linux Success
Details
@Infinisil
Copy link
Member

@Infinisil Infinisil commented Feb 10, 2020

Ah sorry for the delay. It might be a good idea to only open backport PRs if the main one is merged so this doesn't happen (also keeps the discussion in one place).

@wamserma wamserma deleted the wamserma:minidlna-interval branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.