Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] Remove myself from maintainers on some packages #78028

Merged
merged 1 commit into from Jan 20, 2020

Conversation

ivan
Copy link
Member

@ivan ivan commented Jan 19, 2020

Motivation for this change

Removing myself from chromium, qolibri, and scream-receivers because I am not using much desktop Linux right now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/packages-looking-for-a-maintainer/5442/2

@ivan
Copy link
Member Author

ivan commented Jan 20, 2020

cc @alexbakker - if you use scream-receivers, you may wish to add yourself to maintainers on master and release-19.09

qolibri is more obscure, it is possible no one is using it on NixOS, as I was unable to find a NixOS user going through https://github.com/ludios/qolibri/stargazers

@worldofpeace worldofpeace merged commit 383ad09 into NixOS:release-19.09 Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants