Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zchunk: init at 1.1.5 #78040

Closed
wants to merge 1 commit into from
Closed

zchunk: init at 1.1.5 #78040

wants to merge 1 commit into from

Conversation

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Jan 19, 2020

Motivation for this change

From README.md:

zchunk is a compressed file format that splits the file into independent chunks.
This allows you to only download changed chunks when downloading a new version
of the file, and also makes zchunk files efficient over rsync.

zchunk files are protected with strong checksums to verify that the file you
downloaded is, in fact, the file you wanted.

Especially neat is what looks like Fedora has adopted this (might still be under testing?)
for more efficient updating.

https://fedoraproject.org/wiki/Changes/Zchunk_Metadata

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
* argp-standalone for musl
* patches from void for musl (minors)
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 19, 2020
Expects zchunk by default now, added.

cc NixOS#78040
(this PR builds on that one)
@dtzWill dtzWill mentioned this pull request Jan 19, 2020
2 of 10 tasks complete
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 19, 2020
Expects zchunk by default now, added.

cc NixOS#78040
(this PR builds on that one)

(cherry picked from commit b46edad)
};

patches = [
(fetchpatch {

This comment has been minimized.

@jonringer

jonringer Jan 22, 2020
Contributor

can you add comments as to why the patches are needed, and when they can be removed

This comment has been minimized.

@dtzWill

dtzWill Feb 13, 2020
Author Contributor

Good call, sorry for not getting to this. See below.

@dtzWill
Copy link
Contributor Author

@dtzWill dtzWill commented Feb 13, 2020

re:musl patches, see upstream PR 23: zchunk/zchunk#23 .

(which has slightly nicer versions of the fixes, IMO)

Looks like the changes are on track (AFAICT?) for merging, so perhaps we should wait until upstream accepts and then pick those or grab in release bump as appropriate.

@dtzWill
Copy link
Contributor Author

@dtzWill dtzWill commented Feb 13, 2020

#79416 puts this in development/libraries instead of tools/compression--it's both, so don't feel strongly about it. Slight preference for tools since that's a narrowed classification than 'libraries' but honestly maybe no one uses it as the tool proper anyway, couldn't say :).

@dtzWill dtzWill closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.