Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pyproj1: Added support for version 1.9.6 #78092

Closed
wants to merge 1 commit into from

Conversation

@Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Jan 20, 2020

Motivation for this change

Structure for pyproj is very different from pyproj version 2 onwards, Some applications (e. g. Mapproxy) are still using old structure from pyrpoj (1.9.6). So with latest nixpkgs they doesn't work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    @CMCDragonkai @jonringer
@Rakesh4G Rakesh4G requested review from FRidh and jonringer as code owners Jan 20, 2020
@Rakesh4G Rakesh4G changed the title Added pyproj 1.9.6 pythonPackages.pyproj: Added support for version 1.9.6 Jan 20, 2020
@Rakesh4G Rakesh4G mentioned this pull request Jan 20, 2020
3 of 10 tasks complete
@Rakesh4G Rakesh4G changed the title pythonPackages.pyproj: Added support for version 1.9.6 pythonPackages.pyproj1: Added support for version 1.9.6 Jan 21, 2020
Copy link
Contributor

@jonringer jonringer left a comment

we cannot have different versions of the same package within the same package set, if it needs to be overriden, then please override it for the application. Look at aws-sam-cli for an example

@Rakesh4G
Copy link
Contributor Author

@Rakesh4G Rakesh4G commented Jan 22, 2020

we cannot have different versions of the same package within the same package set, if it needs to be overriden, then please override it for the application. Look at aws-sam-cli for an example

OK, @jonringer

@CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Jan 22, 2020

@jonringer There are other packages where "v1s" were left over due to incompatibility with lots of other packages.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 24, 2020

In the python-modules package set, this creates an issue. Because if you're in an environment where packageA needs pyproj1 ,and packageB needs pyproj2, then PYTHONPATH will have both packages on it. However, when it goes to do import pyproj, it will only resolve to one of the packages. This will break either packageA or packageB in a subtle way

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 24, 2020

@jonringer There are other packages where "v1s" were left over due to incompatibility with lots of other packages.

If there are such packages, this was an oversight.

@Rakesh4G
Copy link
Contributor Author

@Rakesh4G Rakesh4G commented Feb 6, 2020

we cannot have different versions of the same package within the same package set, if it needs to be overriden, then please override it for the application. Look at aws-sam-cli for an example

Hi @jonringer
I have updated mapproxy to override pyproj locally.
#68628

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 6, 2020

Ah, that is much more acceptable, as it won't create an in-coherent package set

@FRidh
Copy link
Member

@FRidh FRidh commented Feb 6, 2020

#68628 is merged, so closing this.

@FRidh FRidh closed this Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.