Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.fastavro: init at 0.22.9 #78249

Closed
wants to merge 1 commit into from

Conversation

@arnoldfarkas
Copy link
Contributor

@arnoldfarkas arnoldfarkas commented Jan 22, 2020

Motivation for this change

Adding fastavro to available Python packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@arnoldfarkas arnoldfarkas requested review from FRidh and jonringer as code owners Jan 22, 2020
@ofborg ofborg bot added the 6.topic: python label Jan 22, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 22, 2020

also, eval failed

@arnoldfarkas
Copy link
Contributor Author

@arnoldfarkas arnoldfarkas commented Jan 31, 2020

Test is not run, will update PR (also requires zstandard package)

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 31, 2020

you can also disable selected tests if they require an expensive dependency. The main thing that I'm looking for with tests is some code coverage to ensure that something is broken when a user goes to use the package.

@WorldQuantOS WorldQuantOS force-pushed the WorldQuant:wq_fastavro branch from 687f560 to a4058ef Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.