Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.cpplint: init at 1.4.5 #78252

Closed
wants to merge 1 commit into from

Conversation

@arnoldfarkas
Copy link
Contributor

@arnoldfarkas arnoldfarkas commented Jan 22, 2020

Motivation for this change

Adding cpplint to Python packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@arnoldfarkas arnoldfarkas requested review from FRidh and jonringer as code owners Jan 22, 2020
@ofborg ofborg bot added the 6.topic: python label Jan 22, 2020
@WorldQuantOS WorldQuantOS force-pushed the WorldQuant:wq_cpplint branch from 3a14a4c to 53825c0 Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.