Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite: 3.28.0 -> 3.31.0 (security, backport) #78321

Closed

Conversation

@wamserma
Copy link
Contributor

wamserma commented Jan 22, 2020

Motivation for this change

Backport of #78320, skipping (vulnerable) sqlite 3.30.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@wamserma wamserma changed the title sqlite: 3.28.0 -> 3.31.0 (security) sqlite: 3.28.0 -> 3.31.0 (security, backport) Jan 22, 2020
@wamserma wamserma requested review from c0bw3b and dtzWill Jan 22, 2020
@wamserma
Copy link
Contributor Author

wamserma commented Jan 22, 2020

@GrahamcOfBorg test sqlite

@wamserma wamserma force-pushed the wamserma:sqlite-3.31.0-backport branch from 00f2939 to 2c1d08c Jan 23, 2020
@FRidh
Copy link
Member

FRidh commented Jan 29, 2020

Actual security fixes (patches) should be applied instead.

@wamserma
Copy link
Contributor Author

wamserma commented Jan 29, 2020

Actual security fixes (patches) should be applied instead.

The commit messages do not explicitly mention the CVEs, so pulling out the fixes manually would be a lot of work.
How about building from the last commit on this on this branch? https://sqlite.org/src/timeline?r=branch-3.28 (and someone please check if the fixes are actually in there)

@wamserma
Copy link
Contributor Author

wamserma commented Jan 29, 2020

(and someone please check if the fixes are actually in there)

The CVE entries usually link to a commit on the master branch. Then look up the corresponding parts in the 3.28-branch to confirm the changes made it to the 3.28 branch.

Checklist:

I will update the PR accordingly.

@FRidh FRidh added this to Needs review in Staging (stable) Feb 12, 2020
@veprbl veprbl moved this from Needs review to WIP in Staging (stable) Mar 17, 2020
@veprbl veprbl added this to the 20.03 milestone Mar 17, 2020
@FRidh FRidh removed this from the 20.03 milestone Mar 30, 2020
@wamserma
Copy link
Contributor Author

wamserma commented May 8, 2020

19.09 is EOL. @FRidh merge as is or close (and mark as insecure)?

@FRidh
Copy link
Member

FRidh commented May 9, 2020

We can't backport this update because it would break too much. Marking it as insecure nearly marks the whole of Nixpkgs as unusable, so that's no option either. The only real options we have is creating patches, or leaving it exposed. Given 19.09 is EOL either of the last two is fine.

@FRidh FRidh closed this May 9, 2020
Staging (stable) automation moved this from WIP to Done May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.