Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pxview: init at 0.2.5 #78352

Merged
merged 2 commits into from May 9, 2020
Merged

pxview: init at 0.2.5 #78352

merged 2 commits into from May 9, 2020

Conversation

@winpat
Copy link
Member

winpat commented Jan 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@winpat winpat marked this pull request as ready for review Jan 23, 2020
@winpat winpat changed the title Add pxview pxview: init at 0.2.5 Jan 23, 2020
@mkaito
Copy link
Contributor

mkaito commented Jan 23, 2020

@GrahamcOfBorg build pxview

@mkaito
mkaito approved these changes Jan 23, 2020
pkgs/development/libraries/pxlib/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/pxview/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/pxlib/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/pxview/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/pxview/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/pxview/default.nix Outdated Show resolved Hide resolved
@winpat
Copy link
Member Author

winpat commented Apr 30, 2020

@veprbl Thank you for your feedback. I should be able to incorporate it in the following weekend.

@winpat winpat force-pushed the winpat:add_pxview branch from b4f3284 to 932d641 May 5, 2020
winpat added 2 commits Jan 23, 2020
@veprbl veprbl force-pushed the winpat:add_pxview branch from 932d641 to 9356945 May 5, 2020
@veprbl
veprbl approved these changes May 5, 2020
@veprbl veprbl merged commit 8ceef19 into NixOS:master May 9, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9356945"; rev="9356945f912dfa605ae72e908968d5fa8d7dade6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9356945"; rev="9356945f912dfa605ae72e908968d5fa8d7dade6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9356945"; rev="9356945f912dfa605ae72e908968d5fa8d7dade6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9356945"; rev="9356945f912dfa605ae72e908968d5fa8d7dade6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9356945"; rev="9356945f912dfa605ae72e908968d5fa8d7dade6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9356945"; rev="9356945f912dfa605ae72e908968d5fa8d7dade6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9356945"; rev="9356945f912dfa605ae72e908968d5fa8d7dade6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pxlib, pxlib.passthru.tests, pxview, pxview.passthru.tests on aarch64-linux Success
Details
pxlib, pxlib.passthru.tests, pxview, pxview.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.