Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kapow: init at 1.5.10 #78407

Merged
merged 1 commit into from Oct 4, 2020
Merged

kapow: init at 1.5.10 #78407

merged 1 commit into from Oct 4, 2020

Conversation

@0x450x6c
Copy link

@0x450x6c 0x450x6c commented Jan 24, 2020

Motivation for this change

For add a new package

Things done

Added a new package :)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@eonpatapon
Copy link
Contributor

@eonpatapon eonpatapon commented Feb 5, 2020

Builded it locally, but execution doesn't work for me:

/nix/store/sl5r2n3zxv9d0qmx65arh5y9rzv8lrzz-kapow-1.5.9/bin/kapow

(process:13658): GLib-GIO-ERROR **: 21:50:48.873: No GSettings schemas are installed on the system
Trace/breakpoint trap (core dumped)

Also you should make two commits, one for the package, one for adding yourself in maintainers.

The commit message for adding the package would be: kapow: init at 1.5.9

@stale
Copy link

@stale stale bot commented Aug 3, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale label Aug 3, 2020
@orivej-nixos orivej-nixos changed the title Added a new package: Punch clock program. (time tracker) kapow: init at 1.5.10 Oct 2, 2020
@stale stale bot removed the 2.status: stale label Oct 2, 2020
orivej added a commit to orivej/nixpkgs that referenced this pull request Oct 2, 2020
kapow is an established name of an older project, being packaged in NixOS#78407.
Repology and ArchLinux call the Go project kapowbang because its name is "Kapow!":
https://github.com/BBVA/kapow
https://repology.org/projects/?search=kapow
https://aur.archlinux.org/packages/?K=kapow
@orivej orivej mentioned this pull request Oct 2, 2020
4 of 10 tasks complete
@ofborg ofborg bot added the 8.has: clean-up label Oct 3, 2020
@ofborg ofborg bot requested a review from kalbasit Oct 3, 2020
@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 3, 2020

Split the maintainers file commit.

@orivej
Copy link
Contributor

@orivej orivej commented Oct 4, 2020

I have set myself as the maintainer because the change to maintainers list seemed invalid: azimov.rocks email domain is not registered and 0x769C79DA5C9B038A PGP key is not published. @0x450x6c, please add yourself to maintainers if you still wish to maintain this package (and be notified of its issues and pull requests that edit its definition).

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 4, 2020

What about merge it and include @0x450x6c in a future commit?

@orivej
Copy link
Contributor

@orivej orivej commented Oct 4, 2020

OK.

@AndersonTorres AndersonTorres merged commit e7d8f33 into NixOS:master Oct 4, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
kapow, kapow.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c229834"; rev="c229834d43e6e584a8c87b0334af13e00d80cb6e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c229834"; rev="c229834d43e6e584a8c87b0334af13e00d80cb6e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c229834"; rev="c229834d43e6e584a8c87b0334af13e00d80cb6e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c229834"; rev="c229834d43e6e584a8c87b0334af13e00d80cb6e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c229834"; rev="c229834d43e6e584a8c87b0334af13e00d80cb6e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c229834"; rev="c229834d43e6e584a8c87b0334af13e00d80cb6e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c229834"; rev="c229834d43e6e584a8c87b0334af13e00d80cb6e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kapow, kapow.passthru.tests on x86_64-linux Success
Details
siraben added a commit to siraben/nixpkgs that referenced this pull request Oct 5, 2020
kapow is an established name of an older project, being packaged in NixOS#78407.
Repology and ArchLinux call the Go project kapowbang because its name is "Kapow!":
https://github.com/BBVA/kapow
https://repology.org/projects/?search=kapow
https://aur.archlinux.org/packages/?K=kapow
dawidsowa added a commit to dawidsowa/nixpkgs that referenced this pull request Oct 11, 2020
kapow is an established name of an older project, being packaged in NixOS#78407.
Repology and ArchLinux call the Go project kapowbang because its name is "Kapow!":
https://github.com/BBVA/kapow
https://repology.org/projects/?search=kapow
https://aur.archlinux.org/packages/?K=kapow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.