Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrique: move to aliases.nix, not primary attribute name #78661

Merged
merged 1 commit into from Feb 3, 2020

Conversation

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Jan 28, 2020

Motivation for this change

Noticed when searching for the spectral package:

https://nixos.org/nixos/packages.html?channel=nixos-unstable&query=%5Espectral

.. which presently indicates matrique is the attribute name.

(matrique became spectral at some point in 2018)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Noticed when searching for the spectral package:

https://nixos.org/nixos/packages.html?channel=nixos-unstable&query=%5Espectral

.. which presently indicates `matrique` is the attribute name.

(matrique became spectral at some point in 2018)
@dtzWill dtzWill force-pushed the dtzWill:fix/matrique-alias-for-spectral branch from 61f5363 to 67ab3ba Feb 3, 2020
@dtzWill dtzWill merged commit ccdfbcd into NixOS:master Feb 3, 2020
@dtzWill dtzWill deleted the dtzWill:fix/matrique-alias-for-spectral branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.