Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.untangle: init at 1.1.1 #78693

Closed
wants to merge 1 commit into from

Conversation

@arnoldfarkas
Copy link
Contributor

@arnoldfarkas arnoldfarkas commented Jan 28, 2020

Motivation for this change

Make 'untangle' Python package available in Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
inherit pname version;
sha256 = "e7cfa1ad57707e6b74cfea8b9fc50f7cbe9bbaf18401cc9d72192002bcd80bcb";
};

This comment has been minimized.

@jonringer

jonringer Jan 29, 2020
Contributor

add tests please

Suggested change
checkInputs = [ pytest ];
checkPhase = ''
pytest tests/
'';

looks like you will have to check out from github to pick up tests as well.

Tests are important to make sure the package still works even after bump it's dependencies

This comment has been minimized.

@arnoldfarkas

arnoldfarkas Jan 30, 2020
Author Contributor

Good point, did not see that tests were simply omitted.
Let me review my other PRs as well and update accordingly.

@WorldQuantOS WorldQuantOS force-pushed the WorldQuant:wq_untangle branch from 129dd96 to 986f000 Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.