Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc-arm-bin: init at 9.2-2019.12 #78712

Closed
wants to merge 2 commits into from
Closed

Conversation

@wamserma
Copy link
Contributor

wamserma commented Jan 28, 2020

Motivation for this change

Provide (official) prebuilt cross-compilers for Arm Cortex-A platform
similar to those for Cortex-R/M provided as gcc-arm-embedded.

Please help with testing, especially on AArch64-hosts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Provide (official) prebuilt cross-compilers for Arm Cortex-A platform
similar to those for Cortex-R/M provided as gcc-arm-embedded.
@wamserma
Copy link
Contributor Author

wamserma commented Jan 28, 2020

Ping @prusnak as maintainer of the gcc-arm-embedded packages.

@@ -8232,6 +8232,13 @@ in
gcc-arm-embedded-9 = callPackage ../development/compilers/gcc-arm-embedded/9 {};
gcc-arm-embedded = gcc-arm-embedded-9;

gcc-arm-bin-9 = { target } : callPackage ../development/compilers/gcc-arm-bin/9 { target = target; };

This comment has been minimized.

Copy link
@Mic92

Mic92 Apr 17, 2020

Contributor

What is the difference between the precompiled ones and pkgsCross.armv7l-hf-multiplatform.buildPackages.gcc?

This comment has been minimized.

Copy link
@wamserma

wamserma Apr 17, 2020

Author Contributor

The precompiled ones are sort of "golden reference" versions provided by Arm (regarding exact compiler version, flags etc.). Some projects (e.g. OP-TEE) would download them, but I'm more comfortable with keeping such stuff in the nix store instead of copies cluttering my home.

@Mic92 Mic92 requested a review from Ericson2314 Apr 17, 2020
@Ericson2314
Copy link
Member

Ericson2314 commented Apr 17, 2020

I can't say I am a big fan of this. @matthewbauer did good work removing rebuilt GCCs and proving nice platform cross support. Is there a problem with the cross compilers we build from source?

@wamserma
Copy link
Contributor Author

wamserma commented Apr 17, 2020

I can't say I am a big fan of this. Is there a problem with the cross compilers we build from source?

No, absolutely not. Would you suggest moving this to NUR instead?

@Mic92
Copy link
Contributor

Mic92 commented Apr 17, 2020

@wamserma In case you do put in NUR, you can drop a link in https://nixos.wiki/wiki/Cross_Compiling for better discovery.

@wamserma
Copy link
Contributor Author

wamserma commented May 4, 2020

Moved the PR here: wamserma/nur-packages#2, so anyone still interested can pick it up from there.
@Mic92 given the current state of the build (issues with cachix and patchelf), I will not put this in the Wiki yet.

@wamserma wamserma closed this May 4, 2020
@wamserma wamserma deleted the wamserma:init-gcc-arm-bin branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.