Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appdaemon: 3.0.5 -> 4.0.1 #78734

Merged
merged 2 commits into from Feb 3, 2020
Merged

appdaemon: 3.0.5 -> 4.0.1 #78734

merged 2 commits into from Feb 3, 2020

Conversation

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Jan 28, 2020

Only tested if it builds and tested from commandline

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Mic92 Mic92 requested review from FRidh and jonringer as code owners Jan 28, 2020
@Mic92 Mic92 changed the title Appdaemon appdaemon: 3.0.5 -> 4.0.1 Jan 28, 2020
@ofborg ofborg bot requested review from peterhoeg and dotlambda Jan 28, 2020

meta = with lib; {
description = "Deep Difference and Search of any Python object/data";
homepage = https://github.com/seperman/deepdiff;

This comment has been minimized.

@peterhoeg

peterhoeg Jan 30, 2020
Member

Quote the url please.

# skipped tests require murmur module
checkPhase = ''
py.test -k "not test_prep_str_murmur3_64bit and not test_prep_str_murmur3_128bit" tests
'';

This comment has been minimized.

@peterhoeg

peterhoeg Jan 30, 2020
Member

We have pytestCheckHook that will process disabledTests.

@Mic92 Mic92 force-pushed the Mic92:appdaemon branch from 3f4df09 to ac8f34a Jan 30, 2020
Mic92 added 2 commits Jan 28, 2020
@Mic92 Mic92 force-pushed the Mic92:appdaemon branch from ac8f34a to 4358dff Jan 30, 2020
@ofborg ofborg bot requested a review from peterhoeg Jan 30, 2020
@peterhoeg peterhoeg merged commit f8c5513 into NixOS:master Feb 3, 2020
16 checks passed
16 checks passed
appdaemon on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
appdaemon on aarch64-linux Success
Details
appdaemon on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.