Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesos: fix insecure Maven domain #78764

Closed
wants to merge 0 commits into from
Closed

mesos: fix insecure Maven domain #78764

wants to merge 0 commits into from

Conversation

@jpgu-epam
Copy link

@jpgu-epam jpgu-epam commented Jan 29, 2020

Motivation for this change

Maven insecure domain was changed.
Closes: #78702

Things done

Fix Maven insecure domain for mesos derivation.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jpgu-epam
Copy link
Author

@jpgu-epam jpgu-epam commented Jan 29, 2020

Created replacing #78703

@@ -4,7 +4,7 @@ header "fetching Apache Mesos maven repo"
function fetchArtifact {
repoPath="$1"
echo "Fetching $repoPath"
url="http://repo.maven.apache.org/maven2/$repoPath"
url="http://insecure.repo1.maven.org/maven2/$repoPath"

This comment has been minimized.

@DzmitrySudnik

DzmitrySudnik Feb 4, 2020
Contributor

can you just use https and the old path?

@jpgu-epam jpgu-epam closed this Feb 4, 2020
@jpgu-epam jpgu-epam force-pushed the jpgu-epam:master branch from 280e9d9 to 117b767 Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.