Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guile: disable parallel building for reproducibility #78778

Merged
merged 1 commit into from Oct 21, 2020

Conversation

@grahamc
Copy link
Member

@grahamc grahamc commented Jan 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@alyssais
Copy link
Member

@alyssais alyssais commented Mar 13, 2020

@grahamc is this still an issue? The upstream issue was closed in March.

@andir
Copy link
Member

@andir andir commented Jun 2, 2020

I could still reproduce the issue with the latest release of Guile. I've sent a follow-up mail to their issue tracker since it also occurs when using Guix.

Copy link
Member

@prusnak prusnak left a comment

LGTM

@doronbehar doronbehar merged commit 4696a62 into NixOS:master Oct 21, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants