Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

super-user-spark: 0.3.2.0 -> 0.4.0.4 #78790

Closed
wants to merge 1 commit into from

Conversation

@NorfairKing
Copy link
Contributor

NorfairKing commented Jan 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Waiting for CI to see if this works. if there is CI ... Not sure how to build this locally.

Tom Sydney Kerckhove
@NorfairKing
Copy link
Contributor Author

NorfairKing commented Feb 6, 2020

This doesn't seem to build because genvalidity-path is marked as broken.
How can I find out why that's broken?

@NorfairKing
Copy link
Contributor Author

NorfairKing commented Feb 15, 2020

Also: how would I test building this?

@jlesquembre
Copy link
Contributor

jlesquembre commented Apr 7, 2020

@GrahamcOfBorg build super-user-spark

@jlesquembre
Copy link
Contributor

jlesquembre commented Apr 7, 2020

Thanks for this PR! I think you forgot to update the git revision, shouldn't it be:

  src = fetchgit {
    url = "https://github.com/NorfairKing/super-user-spark";
    sha256 = "1gszgh27vngn5qn8grncc95l8bwrllw5xwawzh6ssrn73wa527ks";
    rev = "17e00e60ee93c2edc71388764922c63f6f941367";
  };

?

Also, after that update, I get an error:

src/SuperUserSpark/OptParse.hs:28:27: error:
    • Couldn't match expected type ‘Options.Applicative.Types.Backtracking’
                  with actual type ‘Bool’
    • In the ‘prefBacktrack’ field of a record
      In the expression:
        ParserPrefs
          {prefMultiSuffix = "", prefDisambiguate = True,
           prefShowHelpOnError = True, prefShowHelpOnEmpty = True,
           prefBacktrack = True, prefColumns = 80}
      In an equation for ‘prefs_’:
          prefs_
            = ParserPrefs
                {prefMultiSuffix = "", prefDisambiguate = True,
                 prefShowHelpOnError = True, prefShowHelpOnEmpty = True,
                 prefBacktrack = True, prefColumns = 80}
   |
28 |         , prefBacktrack = True
   |                           ^^^^

I think is because of optparse-applicative version

@jlesquembre jlesquembre mentioned this pull request Apr 7, 2020
0 of 10 tasks complete
@NorfairKing
Copy link
Contributor Author

NorfairKing commented Apr 7, 2020

@jlesquembre Thanks! I'll fix that. How do you test whether this works?

@jlesquembre
Copy link
Contributor

jlesquembre commented Apr 7, 2020

To test it locally:

nix-build "<nixpkgs>" -A super-user-spark

We can also use GrahamcOfBorg bot after you push your changes. You can see the output here:
https://logs.nix.ci/?key=nixos/nixpkgs.78790&attempt_id=424e298b-4f41-45a9-a985-aa245aaba5cf

To find that link, go to the checks tab, at the bottom, there is a View more details on OfBorg link

@NorfairKing
Copy link
Contributor Author

NorfairKing commented May 9, 2020

No longer maintaining super-user-spark. Use home-manager.

@NorfairKing NorfairKing closed this May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.