Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/doc/network-manager: updates #78838

Merged
merged 1 commit into from Feb 1, 2020
Merged

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 30, 2020

Motivation for this change

Fixes #71161

cc @jtojnar @JohnAZoidberg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace worldofpeace force-pushed the worldofpeace:nm-doc-update branch from 93487cb to cbce59a Feb 1, 2020
@worldofpeace worldofpeace merged commit 9cb395a into NixOS:master Feb 1, 2020
@worldofpeace worldofpeace deleted the worldofpeace:nm-doc-update branch Feb 1, 2020
anna328p added a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.