Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/networking-interfaces: change preferTempAddress to allow disabling temp addresses #78843

Merged
merged 3 commits into from Feb 1, 2020

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 30, 2020

Motivation for this change

Fix issue #75311

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested nixosTests.networking.scripted.privacy nixosTests.networking.networkd.privacy
  • Built manual
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Jan 30, 2020

@GrahamcOfBorg test networking.scripted.privacy networking.networkd.privacy

@rnhmjoj rnhmjoj force-pushed the rnhmjoj:ipv6-privacy branch from d54054d to 9eaf627 Jan 31, 2020
Copy link
Member

@lheckemann lheckemann left a comment

Looks well documented, well thought out and well implemented overall (just one minor nitpick, see inline). I haven't tested this, but if the tests pass I'm happy to merge this with my suggestion applied or as is. Thanks!

// listToAttrs (forEach interfaces
(i: let
opt = i.tempAddress;
val = if opt == "disabled" then 0 else

This comment has been minimized.

@lheckemann

lheckemann Feb 1, 2020
Member

{disabled = 0; enabled = 1; default = 2;}.${opt} might be clearer?

This comment has been minimized.

@rnhmjoj

rnhmjoj Feb 1, 2020
Author Contributor

Oh, nice! I didn't think about this.

@lheckemann
Copy link
Member

@lheckemann lheckemann commented Feb 1, 2020

@GrahamcOfBorg test networking.scripted.privacy networking.networkd.privacy

rnhmjoj added 3 commits Jan 30, 2020
…ing temp addresses
@rnhmjoj rnhmjoj force-pushed the rnhmjoj:ipv6-privacy branch from 9eaf627 to 0c19bfb Feb 1, 2020
@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Feb 1, 2020

Ok, I applied your suggestion. The tests passes on my end. Let's test again with:

@GrahamcOfBorg test networking.scripted.privacy networking.networkd.privacy

@lheckemann lheckemann merged commit 3af5a40 into NixOS:master Feb 1, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.networking.networkd.privacy, tests.networking.scripted.privacy on aarch64-linux Success
Details
tests.networking.networkd.privacy, tests.networking.scripted.privacy on x86_64-linux Success
Details
@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Feb 1, 2020

Thank you!

anna328p added a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
nixos/networking-interfaces: change preferTempAddress to allow disabling temp addresses
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 6, 2020
nixos/networking-interfaces: change preferTempAddress to allow disabling temp addresses

(cherry picked from commit 3af5a40)
@volth
Copy link
Contributor

@volth volth commented Mar 7, 2020

tinc interfaces still have privacy ipv6 addresses (like in #75311 (comment)) even when
networking.interfaces."tinc.dmz".tempAddress = "disabled"
:(

@volth
Copy link
Contributor

@volth volth commented Mar 7, 2020

"net.ipv6.conf.${interface}.addr_gen_mode" = 1 does remove that "stable-privacy" address

interesting that only tinc gets the "stable-privacy" address, other vpn interfaces (wireguard for example) do not

@rnhmjoj rnhmjoj deleted the rnhmjoj:ipv6-privacy branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.