Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elementary-planner: init at 2.1.1 #78859

Merged
merged 3 commits into from Feb 3, 2020

Conversation

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Jan 30, 2020

Motivation for this change

"Never worry about forgetting things again"

cc @worldofpeace

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
dtzWill added 2 commits Jan 30, 2020
Upstream doesn't use the name "elementary-planner",
but rename in our packaging and be consistent about it
to avoid confusion with gnome's planner.
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 30, 2020

So I was a bit worried about this name for second, but it seems their todo app is called tasks https://github.com/elementary/tasks, so there won't be two elementary-planner in here 😄

Copy link
Member

@worldofpeace worldofpeace left a comment

@dtzWill You must be the soverign when it comes to packaging todo apps 😄
Like todo app paradox, within the todo app is a todo to package a todo app. (jk)

Anyways, comments where I mentioned "where is this used?' is because I couldn't find it.
I also would like to see upstream fixing that version string.

gtk3
pantheon.granite
webkitgtk
appstream

This comment has been minimized.

@worldofpeace

worldofpeace Jan 30, 2020
Member

where do we need appstream?

This comment has been minimized.

@jtojnar

jtojnar Jan 31, 2020
Contributor

Possibly for appstream It's file for merging the localisations into appstream file?

This comment has been minimized.

@dtzWill

dtzWill Feb 3, 2020
Author Contributor

Don't remember! Possibly sources:

  • I've been tracking this since before it was usable, maybe it needed/asked for it previously and I missed the drop
  • The in-tree debian/control mentions appstream in Build-Depends: so maybe based initial deps on that list
  • I maybe copied from another expression that does need appstream :3.

In short, thank you for checking these and pushing back on unnecessary deps-- this has been working so I forgot I put it together rather sloppily. Sorry about that :3.

FWIW I believe libical isn't asked for when a sufficiently new libecal (evolution-data-server) but I provided anyway so this works with, for example, my tree which has yet to om nom the gnome 3.34 updates O:).

But I'm happy to remove it, which is why I bring it up ;).

This comment has been minimized.

@dtzWill

dtzWill Feb 3, 2020
Author Contributor

git log -p -Gappstream suggests it was used for things like appstreamcli validate on the appdata.xml or so?

Removing, will see how that pans out :).

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 30, 2020

This thing is pretty cute:
Screenshot from 2020-01-30 09 52 12

Might swap out gnome-todo because it's not seeing releases in a while.

Edit: not the only one who noticed alainm23/planner#185 😁

Per reviewer feedback, thanks all! <3
@dtzWill
Copy link
Contributor Author

@dtzWill dtzWill commented Feb 3, 2020

@dtzWill You must be the soverign when it comes to packaging todo apps smile
Like todo app paradox, within the todo app is a todo to package a todo app. (jk)

LMAO this is very true. I definitely have a TODO for this and others :D.

@dtzWill
Copy link
Contributor Author

@dtzWill dtzWill commented Feb 3, 2020

(pushed update, review feedback should now be addressed!)

@ofborg ofborg bot requested a review from worldofpeace Feb 3, 2020
Copy link
Member

@worldofpeace worldofpeace left a comment

LGTM, thanks a lot 😄

@worldofpeace worldofpeace merged commit 2158ec6 into NixOS:master Feb 3, 2020
16 checks passed
16 checks passed
elementary-planner on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
elementary-planner on aarch64-linux Success
Details
elementary-planner on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Feb 4, 2020
* elementary-planner: init at 2.1.1

* elementary-planner: change pname to match attribute/etc

Upstream doesn't use the name "elementary-planner",
but rename in our packaging and be consistent about it
to avoid confusion with gnome's planner.

* elementary-planner: fetchpatch version fix, dep fixups, maintainers

Per reviewer feedback, thanks all! <3
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Feb 4, 2020
* elementary-planner: init at 2.1.1

* elementary-planner: change pname to match attribute/etc

Upstream doesn't use the name "elementary-planner",
but rename in our packaging and be consistent about it
to avoid confusion with gnome's planner.

* elementary-planner: fetchpatch version fix, dep fixups, maintainers

Per reviewer feedback, thanks all! <3
rkrzr added a commit to rkrzr/nixpkgs that referenced this pull request Feb 16, 2020
* elementary-planner: init at 2.1.1

* elementary-planner: change pname to match attribute/etc

Upstream doesn't use the name "elementary-planner",
but rename in our packaging and be consistent about it
to avoid confusion with gnome's planner.

* elementary-planner: fetchpatch version fix, dep fixups, maintainers

Per reviewer feedback, thanks all! <3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.