Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages_5_5.nvidia_x11: fix build #78869

wants to merge 1 commit into from


Copy link

@arcnmx arcnmx commented Jan 30, 2020

Motivation for this change

It doesn't currently compile, as described here. Some thoughts:

  1. Should the patch be inlined in nixpkgs? I'm not sure if gitlab snippets are like gists where you can link to a specific commit or not, though it seems unlikely that it would be edited again.
  2. Is there an existing beta release we could be using?
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@Ma27 Ma27 commented Feb 5, 2020

Cannot reproduce this with a31341b on my master anymore -> closing.

@Ma27 Ma27 closed this Feb 5, 2020
Copy link
Member Author

@arcnmx arcnmx commented Feb 5, 2020

Yeah #79189 had since been fixed by an update: #79197

@arcnmx arcnmx deleted the arcnmx:pr-nvidia-x11-5.5 branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.