Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcint: init at 3.0.19 #78871

Merged
merged 1 commit into from Feb 3, 2020
Merged

libcint: init at 3.0.19 #78871

merged 1 commit into from Feb 3, 2020

Conversation

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jan 30, 2020

Motivation for this change

Add dependency for upcoming qiskit-terra package #78772

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@drewrisinger
Copy link
Contributor Author

@drewrisinger drewrisinger commented Jan 30, 2020

@GrahamcOfBorg build libcint

@drewrisinger drewrisinger requested a review from timokau Feb 3, 2020
Copy link
Member

@timokau timokau left a comment

The commit name libraries.libcint suggests that libcint is part of the libraries package set (i.e. that you can nix build libraries.libcint. The commit should just be libcint: init....

A rebase on latest master would be nice, since the maintainer commit is already merged.

pkgs/development/libraries/libcint/default.nix Outdated Show resolved Hide resolved
@drewrisinger drewrisinger force-pushed the drewrisinger:dr-pr-libcint branch 2 times, most recently from 8ed31b4 to ecc2922 Feb 3, 2020
C library of general GTO integrals for quantum chemistry.

Requirement for pyscf, which is a requirement for qiskit-aqua.
@drewrisinger drewrisinger changed the title libraries.libcint: init at 3.0.19 libcint: init at 3.0.19 Feb 3, 2020
@drewrisinger drewrisinger force-pushed the drewrisinger:dr-pr-libcint branch from ecc2922 to 3e5789a Feb 3, 2020
@drewrisinger drewrisinger requested a review from timokau Feb 3, 2020
@drewrisinger
Copy link
Contributor Author

@drewrisinger drewrisinger commented Feb 3, 2020

@timokau thanks for your review/comments. Much appreciated. All changes made, and notes made on python2 requirement.

@timokau
timokau approved these changes Feb 3, 2020
@timokau
Copy link
Member

@timokau timokau commented Feb 3, 2020

Looks perfect, thanks!

@timokau timokau merged commit c636a45 into NixOS:master Feb 3, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libcint on aarch64-linux Success
Details
libcint on x86_64-linux Success
Details
@drewrisinger drewrisinger deleted the drewrisinger:dr-pr-libcint branch Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.