Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openrazer: 2.6.0 -> 2.7.0 #78939

Merged
merged 2 commits into from Feb 3, 2020
Merged

openrazer: 2.6.0 -> 2.7.0 #78939

merged 2 commits into from Feb 3, 2020

Conversation

@evanjs
Copy link
Member

@evanjs evanjs commented Jan 31, 2020

Motivation for this change

https://github.com/openrazer/openrazer/releases/tag/v2.7.0

Things done

Built via nixos-rebuild switch on my desktop and verified it still runs normally, at least according to systemctl and journalctl.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

do you mind squashing the last commit into the first?

git rebase -i HEAD~3
# move the last line up one
# pick -> squash
# save
git push .. .. --force
evanjs added 2 commits Jan 30, 2020
openrazer: remove superfluous period from hardware.openrazer.enable
@evanjs evanjs force-pushed the evanjs:openrazer/2.7.0 branch from 1b9b494 to 68bc643 Feb 3, 2020
@evanjs
Copy link
Member Author

@evanjs evanjs commented Feb 3, 2020

Awesome. I'll try to keep trivial changes like that in the same commit as the version bump going forward.
Thanks!

@evanjs evanjs requested a review from jonringer Feb 3, 2020
@ofborg ofborg bot requested a review from roelvandijk Feb 3, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM
diff LGTM (probably should have left it as a separate commit, got confused on which files were being edited)

[0/15 built, 7/0/14 copied (133.2/1271.8 MiB), 110.1/588.4 MiB DL] fetc[8 built, 14 copied (1271.7 MiB), 588.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78939
2 package marked as broken and skipped:
linuxPackages_hardkernel_4_14.openrazer linuxPackages_hardkernel_latest.openrazer

1 package blacklisted:
tests.nixos-functions.nixos-test

18 package built:
linuxPackages-libre.openrazer linuxPackages.openrazer linuxPackages_4_14.openrazer linuxPackages_4_19.openrazer linuxPackages_4_4.openrazer linuxPackages_4_9.openrazer linuxPackages_5_5.openrazer linuxPackages_hardened.openrazer linuxPackages_latest-libre.openrazer linuxPackages_latest_hardened.openrazer linuxPackages_latest_xen_dom0.openrazer linuxPackages_testing_bcachefs.openrazer linuxPackages_testing_hardened.openrazer linuxPackages_xen_dom0.openrazer openrazer-daemon python37Packages.openrazer python38Packages.openrazer python38Packages.openrazer-daemon
@jonringer jonringer merged commit 90dd157 into NixOS:master Feb 3, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.