Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fceux: 2.2.3 -> 2020-01-29 #78943

Merged
merged 1 commit into from Feb 8, 2020
Merged

fceux: 2.2.3 -> 2020-01-29 #78943

merged 1 commit into from Feb 8, 2020

Conversation

@scubed2
Copy link
Contributor

@scubed2 scubed2 commented Jan 31, 2020

Motivation for this change

Version bump for Python 3 compatibility within scons build rule for
#75877

I've manually, locally built with both Python 2 and Python 3 (using above pull request patched in).

I'm using a github snapshot instead of a release because there haven't been any formal releases since 2.2.3 in 2016, but there have been github updates.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@primeos primeos left a comment

Verified the move to GitHub (source) and there might be new releases soon (source).

@scubed2 could you follow e.g. https://github.com/TASVideos/fceux/releases.atom to be notified about new releases?

After the name change this should be good to go, thanks :)

pkgs/misc/emulators/fceux/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/fceux/default.nix Outdated Show resolved Hide resolved
Sterling Stein
@scubed2 scubed2 force-pushed the scubed2:fceux_py3 branch from 416e1ff to 422108c Feb 8, 2020
@primeos primeos changed the title fceux: 2.2.3 -> 2.2.3-20200129 fceux: 2.2.3 -> 2020-01-29 Feb 8, 2020
@primeos
primeos approved these changes Feb 8, 2020
Copy link
Member

@primeos primeos left a comment

LGTM now, thanks :)

@primeos primeos merged commit 4a4834f into NixOS:master Feb 8, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
fceux on aarch64-linux Success
Details
fceux on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 9, 2020
(cherry picked from commit 4a4834f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.