Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: python: fixing mistake in venv example #78953

Merged
merged 1 commit into from Feb 2, 2020

Conversation

@d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Jan 31, 2020

When updating the section to python 3 some places still referred to pythonPackages and were overlooked.
Decided to switch it to be more similar to the first example binding pythonPackages and clarified comments a bit based on confusion I observed on IRC.

Related to #77569

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh @jonringer

Copy link
Contributor

@jonringer jonringer left a comment

LGTM, once comment gets resolved

doc/languages-frameworks/python.section.md Outdated Show resolved Hide resolved
When updating the section to python 3 some places still
referred to pythonPackages and were overlooked.
Decided to switch it to be more similar to the first
example binding pythonPackages and clarified comments a
bit based on confusion I observed on IRC.

Related to #77569
@d-goldin d-goldin force-pushed the d-goldin:python_doc_venv_2 branch from 612ea9a to a9d5dd6 Feb 2, 2020
@jonringer jonringer merged commit e9ba4b9 into NixOS:master Feb 2, 2020
@d-goldin d-goldin deleted the d-goldin:python_doc_venv_2 branch Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.