Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager: 1.22.4 -> 1.22.6 #78997

Merged
merged 2 commits into from Feb 2, 2020
Merged

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 1, 2020

  • also delete unused hardcode-gsettings patch

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/blob/1.22.6/NEWS

Motivation for this change
Things done

Built on master.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace worldofpeace added this to the 20.03 milestone Feb 1, 2020
@worldofpeace worldofpeace requested a review from jtojnar Feb 1, 2020
@worldofpeace worldofpeace added this to WIP in Staging via automation Feb 1, 2020
@worldofpeace worldofpeace moved this from WIP to Needs review in Staging Feb 1, 2020
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 1, 2020

The patch is for network-manager-applet.

@worldofpeace worldofpeace force-pushed the worldofpeace:nm-1.22.6 branch from ceace38 to f025935 Feb 1, 2020
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Feb 1, 2020

The patch is for network-manager-applet.

How funny I forget when I actually wrote the patch 🤣
I forced pushed to reorganize the directory.

@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Feb 1, 2020

Now that I think of it, I don't need that hardcode patch anymore for wingpanel and switchboard,

Staging automation moved this from Needs review to Ready Feb 1, 2020
@jtojnar
jtojnar approved these changes Feb 1, 2020
Copy link
Contributor

@jtojnar jtojnar left a comment

LGTM.

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 1, 2020

IMHO they still make sense for other uses.

Also we should start thinking where we will place libnma.

@ofborg ofborg bot requested review from Phreedom, jensbin, domenkozar and obadz Feb 1, 2020
@worldofpeace worldofpeace merged commit 50ac34e into NixOS:staging Feb 2, 2020
15 of 16 checks passed
15 of 16 checks passed
networkmanager on aarch64-linux
Details
networkmanager on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
networkmanager on x86_64-linux Success
Details
Staging automation moved this from Ready to Done Feb 2, 2020
@worldofpeace worldofpeace deleted the worldofpeace:nm-1.22.6 branch Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.