Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager_dmenu: 1.1 -> 1.5.0 #78999

Merged
merged 1 commit into from Jun 25, 2020
Merged

Conversation

@magnetophon
Copy link
Member

@magnetophon magnetophon commented Feb 1, 2020

Motivation for this change

Update to the latest release.
The current nixpkgs version is ancient.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@magnetophon magnetophon force-pushed the magnetophon:networkmanager_dmenu branch from e60e560 to 3c984b1 Feb 2, 2020
@magnetophon magnetophon changed the title networkmanager_dmenu: 1.1 -> unstable-2020-01-26 networkmanager_dmenu: 1.1 -> 1.5.0 Feb 2, 2020
@magnetophon
Copy link
Member Author

@magnetophon magnetophon commented Feb 2, 2020

Done.

@magnetophon magnetophon force-pushed the magnetophon:networkmanager_dmenu branch from 3c984b1 to 2c25f89 Apr 19, 2020
@magnetophon
Copy link
Member Author

@magnetophon magnetophon commented Apr 19, 2020

I totally missed the conflict. Fixed now!

@Pacman99
Copy link

@Pacman99 Pacman99 commented May 24, 2020

The update/pr builds and works perfectly for me. It adds significant improvements to the program. It would be really great if it could be merged

@magnetophon
Copy link
Member Author

@magnetophon magnetophon commented Jun 20, 2020

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 20, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Jun 20, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@magnetophon
Copy link
Member Author

@magnetophon magnetophon commented Jun 20, 2020

/status needs_merge

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Jun 20, 2020

Sorry, you cannot set your own PR to needs_merge. Please wait for an external review. You may also actively search out a reviewer by pinging relevant people (look at the history of the files you're changing) or posting on discourse or IRC.

@magnetophon
Copy link
Member Author

@magnetophon magnetophon commented Jun 20, 2020

/status needs_review

@marvin-mk2 marvin-mk2 bot added the needs_reviewer label Jun 20, 2020
@timokau
Copy link
Member

@timokau timokau commented Jun 25, 2020

Thanks!
/status needs_merge

@marvin-mk2 marvin-mk2 bot added needs_merger and removed needs_reviewer labels Jun 25, 2020
@marvin-mk2 marvin-mk2 bot requested a review from timokau Jun 25, 2020
@timokau timokau merged commit 2957459 into NixOS:master Jun 25, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c25f89"; rev="2c25f8934427f1f60e4ae564282aaa451cf0222a"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c25f89"; rev="2c25f8934427f1f60e4ae564282aaa451cf0222a"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c25f89"; rev="2c25f8934427f1f60e4ae564282aaa451cf0222a"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c25f89"; rev="2c25f8934427f1f60e4ae564282aaa451cf0222a"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c25f89"; rev="2c25f8934427f1f60e4ae564282aaa451cf0222a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c25f89"; rev="2c25f8934427f1f60e4ae564282aaa451cf0222a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c25f89"; rev="2c25f8934427f1f60e4ae564282aaa451cf0222a"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
networkmanager_dmenu, networkmanager_dmenu.passthru.tests on aarch64-linux Success
Details
networkmanager_dmenu, networkmanager_dmenu.passthru.tests on x86_64-linux Success
Details
@timokau
Copy link
Member

@timokau timokau commented Jun 25, 2020

(And sorry this has been sitting idle for way too long)

@magnetophon
Copy link
Member Author

@magnetophon magnetophon commented Jun 25, 2020

@timokau No need to apologize, there's a lot more PR's than maintainers at the moment.

So thank you!

@magnetophon magnetophon deleted the magnetophon:networkmanager_dmenu branch Jun 25, 2020
@marvin-mk2 marvin-mk2 bot added awaiting_merger and removed needs_merger labels Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.