Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MozPhab: init at 0.1.74 #79012

Closed
wants to merge 1 commit into from
Closed

MozPhab: init at 0.1.74 #79012

wants to merge 1 commit into from

Conversation

@raboof
Copy link
Contributor

@raboof raboof commented Feb 1, 2020

Motivation for this change

MozPhab is the recommended tool for submitting patches to Mozilla Firefox.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@raboof raboof changed the title ###### Motivation for this change MozPhab: init at 0.1.74 Feb 1, 2020
@@ -5777,6 +5777,11 @@
fingerprint = "7573 56D7 79BB B888 773E 415E 736C CDF9 EF51 BD97";
}];
};
raboof = {

This comment has been minimized.

@sikmir

sikmir Feb 2, 2020
Member

Adding yourself as a maintainer is preferred to be a separate commit.
Something like, maintainers: add raboof. Then apply the MozPhab commit.

@raboof raboof force-pushed the raboof:init-moz-phab branch 2 times, most recently from 79393f4 to cedec2d Feb 2, 2020
@raboof
Copy link
Contributor Author

@raboof raboof commented Feb 2, 2020

@sikmir thanks for the review - updated accordingly!

@raboof raboof requested a review from sikmir Mar 1, 2020
@sikmir
sikmir approved these changes Mar 1, 2020
@raboof raboof force-pushed the raboof:init-moz-phab branch from cedec2d to 2b1a779 Apr 6, 2020
@grahamc
Copy link
Member

@grahamc grahamc commented Apr 6, 2020

@raboof
Copy link
Contributor Author

@raboof raboof commented Apr 7, 2020

abandoning this for now until I want to do a mozilla contribution again :)

@raboof raboof closed this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.