Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/openarena: run real openarena clients #79016

Merged
merged 1 commit into from Feb 13, 2020

Conversation

@fpletz
Copy link
Member

@fpletz fpletz commented Feb 1, 2020

Motivation for this change

The old Quake3 NixOS test was removed in 50ea99c which served as a nice demo to showcase what NixOS tests are capable of. This commit adds the same functionality to run real openarena clients.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The old Quake3 NixOS test was removed in
50ea99c which served as a nice demo to
showcase what NixOS tests are capable of. This commit adds the same
functionality to run real openarena clients.
@fpletz fpletz force-pushed the mayflower:nixos/openarena-test branch from 5ba6387 to 9f1c76f Feb 1, 2020
@Ma27
Ma27 approved these changes Feb 1, 2020
"journalctl -u openarena.service | grep 'resolve address: dpmaster.deathmask.net'"
)
server.wait_for_unit("openarena")
server.wait_until_succeeds("ss --numeric --udp --listening | grep -q 27960")

This comment has been minimized.

@rnhmjoj

rnhmjoj Feb 1, 2020
Contributor

Isn't there a wait_for_open_port()?

This comment has been minimized.

@fpletz

fpletz Feb 1, 2020
Author Member

Unfortunately this function only checks for TCP ports.

@mmahut
Copy link
Member

@mmahut mmahut commented Feb 13, 2020

@GrahamcOfBorg test openarena

@mmahut mmahut merged commit 004b379 into NixOS:master Feb 13, 2020
14 checks passed
14 checks passed
tests.openarena on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.openarena on x86_64-linux Success
Details
@Ma27 Ma27 deleted the mayflower:nixos/openarena-test branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.