Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ytop: init at 0.4.0 #79021

Merged
merged 1 commit into from Feb 2, 2020
Merged

ytop: init at 0.4.0 #79021

merged 1 commit into from Feb 2, 2020

Conversation

@sikmir
Copy link
Member

@sikmir sikmir commented Feb 1, 2020

Motivation for this change

From cjbassi/gotop README:

NO LONGER MAINTAINED. Future development has moved to ytop, a Rust port of gotop.

cjbassi/ytop - a TUI system monitor written in Rust.

cc @magnetophon, @marsam

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh ./result
/nix/store/cf0495whapdjgdafdj6mw9spsycygal1-ytop-0.4.0	 29.4M
@magnetophon
Copy link
Member

@magnetophon magnetophon commented Feb 1, 2020

lgtm!

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 2, 2020

@sikmir Can we remove gotop and add migration instructions in aliases.nix?

Edit: it doesn't seem abandoned though.

@magnetophon
Copy link
Member

@magnetophon magnetophon commented Feb 2, 2020

@worldofpeace What do you mean? The readme is pretty clear, isn't it?

@sikmir sikmir force-pushed the sikmir:ytop branch from a56935b to 4368616 Feb 2, 2020
@sikmir
Copy link
Member Author

@sikmir sikmir commented Feb 2, 2020

@sikmir Can we remove gotop and add migration instructions in aliases.nix?

There is no parity in functionality between ytop and gotop yet (e.g. mouse usage isn't implemented in ytop yet). So I would say we can remove gotop at some point in the future (maybe when ytop 1.x.x will be out), but not now.

@marsam marsam merged commit c7458ab into NixOS:master Feb 2, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ytop on aarch64-linux Success
Details
ytop on x86_64-linux Success
Details
@marsam
Copy link
Contributor

@marsam marsam commented Feb 2, 2020

Thank you @sikmir. I agree we can remove gotop later.

@sikmir sikmir deleted the sikmir:ytop branch Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.