Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ispell: fix hash and drop patches #79025

Open
wants to merge 1 commit into
base: master
from

Conversation

@tadeokondrak
Copy link
Member

@tadeokondrak tadeokondrak commented Feb 1, 2020

Motivation for this change

#64285 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lheckemann
Copy link
Member

@lheckemann lheckemann commented Feb 1, 2020

If we're not applying the patches anymore, we should probably also remove them from nixpkgs.

Copy link
Member

@worldofpeace worldofpeace left a comment

See @lheckemann comment

This was added only to build hunspellDicts.de_DE: [1]
The patches came from an older PR (taken from Debian): [2]
but aren't needed to build the dictionary.

[1]: #36155
[2]: #3320
@tadeokondrak tadeokondrak force-pushed the tadeokondrak:ispell-fix-hash branch from 89c5349 to ef31752 Feb 2, 2020
./patches/0023-Exclusive-options.patch
./patches/0024-Check-tempdir-creation.patch
./patches/0025-Languages.patch
./patches/0030-Display-whole-multibyte-character.patch

This comment has been minimized.

@jtojnar

jtojnar Feb 2, 2020
Contributor

Some of these still might make sense when updated from https://salsa.debian.org/debian/ispell/tree/debian/3.4.00-8/debian/patches. Why they did not upstream them even after all these years is beyond me.

Or if this is intended only for the German dictionary we might make it local as originally suggested.

Or maybe we are fine with vanilla ispell, even though some of those patches look like they should definitely be upstreamed.

@Ekleog
Copy link
Member

@Ekleog Ekleog commented Jun 11, 2020

I'd vote for just landing this, up-to-date vanilla ispell probably is better matching the nixos way of doing things than debian-old ispell.

@jtojnar What do you think about merging this as is?

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jun 12, 2020

I would definitely prefer vanilla package but would like still hear from @timor or @bennofs why they included these patches.

@GrahamcOfBorg build hunspellDicts.de-de hunspellDicts.de-ch hunspellDicts.de-at

@timor
Copy link
Member

@timor timor commented Jun 12, 2020

I cannot comment on these patches, sorry. I merely re-used @bennofs' code (for the sole purpose of building the German hunspell dictionaries).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.