Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blackmagic: v1.6.1-317-gc9c8b08 -> v1.6.1-409-g7a595ea (add new targets) #79026

Merged
merged 2 commits into from Mar 2, 2020

Conversation

@sorki
Copy link
Member

@sorki sorki commented Feb 1, 2020

Motivation for this change

Update to more recent version. Also exposes hosted targets which can be run on host system instead of microcontroller (requires libusb and pkg-config).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@emilazy
emilazy approved these changes Feb 1, 2020
Copy link
Member

@emilazy emilazy left a comment

LGTM. Sorry for not getting around to this myself; I was hoping there'd be a tagged upstream release sooner.

@GrahamcOfBorg build blackmagic

@mmahut
Copy link
Member

@mmahut mmahut commented Feb 4, 2020

@GrahamcOfBorg build blackmagic

@emilazy
Copy link
Member

@emilazy emilazy commented Feb 5, 2020

Looks like stdenv is passing down CFLAGS it shouldn't to arm-embedded-gcc on Darwin. If you're not sure how to fix that, probably best just to mark it as only building on Linux for now?

@mmilata
Copy link
Member

@mmilata mmilata commented Feb 19, 2020

fyi ZHF: #80379

@emilazy
Copy link
Member

@emilazy emilazy commented Feb 19, 2020

Hopefully the bump will fix the error, but whoever merges should make sure to switch platforms to Linux-only so they don't introduce a new one in the process ^^;

@sorki
Copy link
Member Author

@sorki sorki commented Feb 19, 2020

I'll take a look and update to more recent version as well.

sorki added 2 commits Feb 1, 2020
Add myself to maintainers and change meta.platforms to platforms.linux
due to build failures on Darwin.
@sorki sorki force-pushed the sorki:bmp branch from 259b4bd to 87057d9 Feb 20, 2020
@sorki
Copy link
Member Author

@sorki sorki commented Feb 20, 2020

Bumped version, now uses platforms.linux instead of platforms.unix. I've also added myself to maintainers.

@ofborg ofborg bot added the 8.has: clean-up label Feb 20, 2020
@ofborg ofborg bot requested a review from emilazy Feb 20, 2020
@sorki sorki changed the title blackmagic: v1.6.1-317-gc9c8b08 -> v1.6.1-404-gc3a3f77 (add new targets) blackmagic: v1.6.1-317-gc9c8b08 -> v1.6.1-409-g7a595ea (add new targets) Feb 20, 2020
@mmahut
Copy link
Member

@mmahut mmahut commented Feb 25, 2020

@GrahamcOfBorg build blackmagic

@vcunat
vcunat approved these changes Mar 2, 2020
vcunat added a commit that referenced this pull request Mar 2, 2020
(cherry picked from commit 855f020)
It didn't build before this bump.
@vcunat vcunat merged commit 855f020 into NixOS:master Mar 2, 2020
16 checks passed
16 checks passed
blackmagic on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
blackmagic on aarch64-linux Success
Details
blackmagic on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.