Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lilypond: allow building on Darwin #79040

Merged
merged 2 commits into from Feb 2, 2020
Merged

Conversation

@bdesham
Copy link
Contributor

@bdesham bdesham commented Feb 1, 2020

Motivation for this change

LilyPond was marked broken on Darwin in commit 287ab73. I’m not sure what’s changed, but I tried building it on my macOS 10.14 (Mojave) machine just now and it built and ran without a problem.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot added the 6.topic: darwin label Feb 1, 2020
@veprbl
Copy link
Member

@veprbl veprbl commented Feb 1, 2020

For the reason, there is an explanation in the 4th bullet in #62937
cc @yurrriq

@GrahamcOfBorg build lilypond
@GrahamcOfBorg build lilypond-unstable
@GrahamcOfBorg build lilypond-with-fonts

@bdesham bdesham force-pushed the bdesham:allow-lilypond-on-darwin branch from 1d1380f to 69f4b8c Feb 2, 2020
@bdesham
Copy link
Contributor Author

@bdesham bdesham commented Feb 2, 2020

Ah, I see. I can reproduce locally the failures with lilypond-unstable and lilypond-with-fonts. I think it would make sense to at least mark lilypond itself as not broken. I’ve changed the PR so that it unmarks lilypond as broken on Darwin but leaves lilypond-unstable marked broken.

It also makes sense to me to use lilypond, not lilypond-unstable, as the basis of lilypond-with-fonts on Darwin. I’m not sure what to do about openlilylib-fonts, though. It depends on lilypond, but it doesn’t actually use LilyPond—it just uses that derivation’s version number to construct its own paths. Does it make sense for openlilylib-fonts to be its own top-level package? It seems to me like it might make more sense bundled into lilypond-with-fonts.

@yurrriq
Copy link
Member

@yurrriq yurrriq commented Feb 2, 2020

lilypond-with-fonts could definitely use a rewrite. I think I might even have one locally. I can't remember now, but do custom fonts depend on 2.19.x? If not, 👍 to supporting with-fonts on 2.18 (stable). Thanks for testing on Darwin and for this PR!

@yurrriq
yurrriq approved these changes Feb 2, 2020
@veprbl veprbl merged commit 9905f6d into NixOS:master Feb 2, 2020
14 checks passed
14 checks passed
lilypond, lilypond-unstable on aarch64-linux Failure
Details
lilypond, lilypond-unstable on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bdesham
Copy link
Contributor Author

@bdesham bdesham commented Feb 3, 2020

Thank you! Let me know if you need assistance getting any LilyPond stuff working on Darwin.

@bdesham bdesham deleted the bdesham:allow-lilypond-on-darwin branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.