Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby-gnome: 3.3.7 -> 3.4.1 #79051

Closed
wants to merge 8 commits into from
Closed

Conversation

@ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Feb 1, 2020

Motivation for this change

The most recent glib bump broke rubyPackages.glib2. https://hydra.nixos.org/build/111030999

Things done

I have upgraded all the package from the ruby-gnome project from version 3.3.7 to the latest version 3.4.1. Although it went from 3.3 to 3.4 there were no breaking changes and 3.4 so far has just been bug fixes.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ahiaao
Copy link
Contributor Author

@ahiaao ahiaao commented Feb 18, 2020

closed by #76595

@ahiaao ahiaao closed this Feb 18, 2020
@ahiaao ahiaao deleted the ahiaao:fix/ruby-gnome-3.4.1 branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.