Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hercules: init at 3.13 (attempt 2) #79069

Merged
merged 1 commit into from Mar 26, 2020
Merged

hercules: init at 3.13 (attempt 2) #79069

merged 1 commit into from Mar 26, 2020

Conversation

@dkudriavtsev
Copy link
Member

dkudriavtsev commented Feb 2, 2020

Motivation for this change

Add the Hercules IBM mainframe emulator to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
jakobrs added a commit to jakobrs/nixpkgs that referenced this pull request Feb 16, 2020
Adds a package for VVVVVV, a platform game based on inverting gravity.

Relevant:

- NixOS#77519
- NixOS#78319
- NixOS#79069
- TerryCavanagh/VVVVVV#139
- TerryCavanagh/VVVVVV#153
- TerryCavanagh/VVVVVV#155
- TerryCavanagh/VVVVVV#156

Co-authored-by: jakobrs <jakobrs100@gmail.com>
Co-authored-by: leo60228 <iakornfeld@gmail.com>
jakobrs added a commit to jakobrs/nixpkgs that referenced this pull request Feb 16, 2020
Adds a package for VVVVVV, a platform game based on inverting gravity.

Relevant:

- NixOS#77519
- NixOS#78319
- NixOS#79069
- TerryCavanagh/VVVVVV#139
- TerryCavanagh/VVVVVV#153
- TerryCavanagh/VVVVVV#155
- TerryCavanagh/VVVVVV#156

- git log at eb3527f

Co-authored-by: jakobrs <jakobrs100@gmail.com>
Co-authored-by: leo60228 <iakornfeld@gmail.com>
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Mar 17, 2020

@dkudriavtsev

This comment has been minimized.

Copy link
Member Author

dkudriavtsev commented Mar 18, 2020

@jonringer This fails because the packages are served over HTTP and the CI doesn't want to fetch the HTTP source because it's in restricted mode

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Mar 18, 2020

interesting. cc @grahamc opinions?

@lightdiscord

This comment has been minimized.

Copy link
Member

lightdiscord commented Mar 20, 2020

HTTP url seems to work with the bot.
For example here is an HTTP url and here is the PR and it seems the bot (ofborg) works fine.

The problem may come because you're using builtins.fetchurl instead of pkgs.fetchurl ?

@dkudriavtsev dkudriavtsev force-pushed the dkudriavtsev:hercules branch from ac1b27e to f09ce61 Mar 25, 2020
@dkudriavtsev

This comment has been minimized.

Copy link
Member Author

dkudriavtsev commented Mar 25, 2020

@jonringer @lightdiscord updated, hopefully it works

@dkudriavtsev dkudriavtsev force-pushed the dkudriavtsev:hercules branch from f09ce61 to 64cafe8 Mar 25, 2020
@dkudriavtsev

This comment has been minimized.

Copy link
Member Author

dkudriavtsev commented Mar 25, 2020

@jonringer resolved

Copy link
Contributor

jonringer left a comment

diff LGTM
commit LGTM

https://github.com/NixOS/nixpkgs/pull/79069
1 package built:
hercules
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Mar 26, 2020

@GrahamcOfBorg build hercules

@jonringer jonringer merged commit e882dfe into NixOS:master Mar 26, 2020
15 of 16 checks passed
15 of 16 checks passed
hercules on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
hercules on aarch64-linux Success
Details
hercules on x86_64-darwin Success
Details
@dkudriavtsev dkudriavtsev deleted the dkudriavtsev:hercules branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.