Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x3270: init at 4.0ga9 #79072

Merged
merged 1 commit into from Aug 15, 2020
Merged

x3270: init at 4.0ga9 #79072

merged 1 commit into from Aug 15, 2020

Conversation

@anna328p
Copy link
Member

@anna328p anna328p commented Feb 2, 2020

Motivation for this change

Adds x3270, an IBM 3270 terminal emulator for the X Window System, to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sikmir
Copy link
Member

@sikmir sikmir commented Feb 2, 2020

Could you please squash commits into one?

@anna328p
Copy link
Member Author

@anna328p anna328p commented Feb 2, 2020

Could you please squash commits into one?

Doesn't Github have an option to automatically do that when merging a pull request?

@anna328p
Copy link
Member Author

@anna328p anna328p commented Mar 26, 2020

@sikmir Done

@jonringer
Copy link
Contributor

@jonringer jonringer commented May 6, 2020

there still some merge conflicts.

Generally rebasing is prefered over merging:

git pull -r origin master
@anna328p anna328p force-pushed the anna328p:x3270 branch from 1f514b3 to 61c40b9 Jul 16, 2020
@anna328p
Copy link
Member Author

@anna328p anna328p commented Jul 16, 2020

@jonringer Fixed the merge conflicts, bumped the package version, and rebased to latest master.

Dropped the patch that removed references to /bin from the Makefile because it was merged into upstream.

@anna328p anna328p changed the title x3270: init at 3.6ga8 x3270: init at 4.0ga9 Jul 19, 2020
@anna328p anna328p force-pushed the anna328p:x3270 branch 2 times, most recently from 05ad071 to b1424cd Jul 29, 2020
@anna328p anna328p force-pushed the anna328p:x3270 branch from b1424cd to c375dc7 Jul 29, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/79072
1 package built:
x3270
@jonringer jonringer merged commit 08930e0 into NixOS:master Aug 15, 2020
17 checks passed
17 checks passed
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c375dc7"; rev="c375dc788d3caa3a35d9f2b39ed3e57cb547e3c9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c375dc7"; rev="c375dc788d3caa3a35d9f2b39ed3e57cb547e3c9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c375dc7"; rev="c375dc788d3caa3a35d9f2b39ed3e57cb547e3c9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c375dc7"; rev="c375dc788d3caa3a35d9f2b39ed3e57cb547e3c9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c375dc7"; rev="c375dc788d3caa3a35d9f2b39ed3e57cb547e3c9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c375dc7"; rev="c375dc788d3caa3a35d9f2b39ed3e57cb547e3c9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c375dc7"; rev="c375dc788d3caa3a35d9f2b39ed3e57cb547e3c9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
x3270, x3270.passthru.tests on aarch64-linux Success
Details
x3270, x3270.passthru.tests on x86_64-linux Success
Details
@anna328p anna328p deleted the anna328p:x3270 branch Aug 15, 2020
@anna328p anna328p restored the anna328p:x3270 branch Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.