Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.bclose-vim: initi at 2018-10-10 #79076

Merged
merged 2 commits into from Feb 2, 2020
Merged

Conversation

@equirosa
Copy link
Contributor

@equirosa equirosa commented Feb 2, 2020

Motivation for this change

Added vim plugin bclose

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@softinio softinio left a comment

Looks good to me. Thank you!

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commits LGTM

[164 built, 38 copied (999.0 MiB), 232.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79076
83 package built:
vimPlugins.SpaceCamp vimPlugins.bclose-vim vimPlugins.calendar-vim vimPlugins.caw-vim vimPlugins.coc-eslint vimPlugins.coc-git vimPlugins.coc-metals vimPlugins.coc-snippets vimPlugins.defx-git vimPlugins.defx-icons vimPlugins.defx-nvim vimPlugins.denite-nvim vimPlugins.deoplete-fish vimPlugins.deoplete-jedi vimPlugins.deoplete-khard vimPlugins.deoplete-nvim vimPlugins.echodoc-vim vimPlugins.editorconfig-vim vimPlugins.ensime-vim vimPlugins.far-vim vimPlugins.ghcid vimPlugins.gist-vim vimPlugins.gv-vim vimPlugins.iosvkem vimPlugins.jedi-vim vimPlugins.lightline-ale vimPlugins.lightline-vim vimPlugins.neocomplete-vim vimPlugins.neomake vimPlugins.neosnippet-snippets vimPlugins.neosnippet-vim vimPlugins.nerdcommenter vimPlugins.nerdtree vimPlugins.nvim-gdb vimPlugins.nvim-lsp vimPlugins.open-browser-vim vimPlugins.palenight-vim vimPlugins.rust-vim vimPlugins.syntastic vimPlugins.tagbar vimPlugins.thumbnail-vim vimPlugins.traces-vim vimPlugins.tsuquyomi vimPlugins.unicode-vim vimPlugins.vader-vim vimPlugins.vim-airline vimPlugins.vim-airline-themes vimPlugins.vim-autoformat vimPlugins.vim-cursorword vimPlugins.vim-dirvish vimPlugins.vim-easymotion vimPlugins.vim-elm-syntax vimPlugins.vim-fetch vimPlugins.vim-fugitive vimPlugins.vim-gitgutter vimPlugins.vim-go vimPlugins.vim-haskellConcealPlus vimPlugins.vim-highlightedyank vimPlugins.vim-javascript vimPlugins.vim-lastplace vimPlugins.vim-mucomplete vimPlugins.vim-obsession vimPlugins.vim-pandoc vimPlugins.vim-pandoc-syntax vimPlugins.vim-pathogen vimPlugins.vim-plug vimPlugins.vim-polyglot vimPlugins.vim-ruby vimPlugins.vim-snippets vimPlugins.vim-subversive vimPlugins.vim-terraform vimPlugins.vim-test vimPlugins.vim-visual-multi vimPlugins.vim-yaml vimPlugins.vimproc-vim vimPlugins.vimshell-vim vimPlugins.vimtex vimPlugins.vista-vim vimPlugins.wal-vim vimPlugins.yats-vim vimPlugins.youcompleteme vimPlugins.zenburn vimPlugins.zig-vim
@jonringer jonringer merged commit 73c51e0 into NixOS:master Feb 2, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vimPlugins.bclose-vim on aarch64-linux Success
Details
vimPlugins.bclose-vim on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.