Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fusee-interface-tk: init at 1.0.0 #79082

Closed
wants to merge 2 commits into from
Closed

Conversation

@Kristian-Brucaj
Copy link
Contributor

@Kristian-Brucaj Kristian-Brucaj commented Feb 2, 2020

Add fusee-interfacee-tk package to applications/misc
Added self as maintainer to fusee-interface-tk

Motivation for this change

Wanted to use fusee-interface-tk from https://github.com/nh-server/fusee-interfacee-tk in NixOS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Add fusee-interface-tk package to applications/misc
Added self as maintainer to fusee-interface-tk
@sikmir
Copy link
Member

@sikmir sikmir commented Feb 2, 2020

Add fusee-interface-tk package to applications/misc
Added self as maintainer to fusee-interface-tk

Adding yourself as a maintainer is preferred to be a separate commit.
Something like, maintainers: add kristian-brucaj. Then apply the fusee-interface-tk commit.

@@ -3451,6 +3451,8 @@ in
fuse-7z-ng = callPackage ../tools/filesystems/fuse-7z-ng { };

fuse-overlayfs = callPackage ../tools/filesystems/fuse-overlayfs {};

fusee-interface-tk = callPackage ../applications/misc/fusee-interface-tk { };

This comment has been minimized.

@sikmir

sikmir Feb 2, 2020
Member

Consider using:

Suggested change
fusee-interface-tk = callPackage ../applications/misc/fusee-interface-tk { };
fusee-interface-tk = python3Packages.callPackage ../applications/misc/fusee-interface-tk { };
{ stdenv , fetchFromGitHub , python3 , makeWrapper }:

let pythonEnv = python3.withPackages(ps: [ ps.tkinter ps.pyusb ]);
in stdenv.mkDerivation {

This comment has been minimized.

@sikmir

sikmir Feb 2, 2020
Member

Consider using:

Suggested change
in stdenv.mkDerivation {
buildPythonApplication rec {

This comment has been minimized.

@Kristian-Brucaj

Kristian-Brucaj Feb 2, 2020
Author Contributor

The reason I'm not using buildPythonApplication is that the package is structured oddly and lacks a setup.py. I plan to try and cobble one together later, but for now the stdenv.mkDerivation should be used. The same applies to the prior and next suggestions.

};

nativeBuildInputs = [ makeWrapper ];
buildInputs = [ pythonEnv ];

This comment has been minimized.

@sikmir

sikmir Feb 2, 2020
Member

Maybe something like:

Suggested change
buildInputs = [ pythonEnv ];
propagatedBuildInputs = [ tkinter pyusb ];
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.