Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpv plugin bookmark 20180320.lua #79092

Open
wants to merge 2 commits into
base: master
from

Conversation

@feijoas
Copy link
Contributor

@feijoas feijoas commented Feb 2, 2020

mpv-plugin-bookmark

mpv plugin for recording last play in current playing folder and you can resume to play

this plugin will also load the playlist from the playing folder automatically

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@feijoas
Copy link
Contributor Author

@feijoas feijoas commented Feb 2, 2020

@jfrankenau Can you review this PR?

@jfrankenau
Copy link
Contributor

@jfrankenau jfrankenau commented Apr 30, 2020

What is the difference between the upstream light and master branch? The former one is the default one. Also please squash those commits.

owner = "yozorayuki";
repo = "mpv-plugin-bookmark";
rev = "08fa0a415a4a220a91b8436ca681e3da92120b9d";
sha256 = "0ann6c2rajy36a6w72l2q6288r6v03ha278i5qh5hk6r9q6gkhy8";

This comment has been minimized.

@Mic92

Mic92 Apr 30, 2020
Contributor

You can return fetchFromGithub directly instead of wrapping it into a stdenv.mkDerivation.

Checksum also needs a fix in that case:

Suggested change
sha256 = "0ann6c2rajy36a6w72l2q6288r6v03ha278i5qh5hk6r9q6gkhy8";
name = "mpv-plugin-bookmark-20180320.lua";
sha256 = "0ann6c2rajy36a6w72l2q6288r6v03ha278i5qh5hk6r9q6gkhy8";
postFetch = ''
cp bookmark.lua $out
'';
meta = with lib; {
description = "mpv plugin to record your playing history for each folder and you can choose resume to play next time";
homepage = https://github.com/yozorayuki/mpv-plugin-bookmark;
license = licenses.asl20;
maintainers = [ maintainers.mschneider ];
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.