Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation-cd-graphical-base.nix: adding git #79098

Merged
merged 1 commit into from Feb 14, 2020

Conversation

@snicket2100
Copy link
Contributor

snicket2100 commented Feb 2, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Ma27
Ma27 approved these changes Feb 2, 2020
@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Feb 3, 2020

I believed we discussed also adding mercurial here as well if it's for the graphical image.
cc @alyssais @grahamc @edolstra

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented Feb 3, 2020

@danbst

This comment has been minimized.

Copy link
Contributor

danbst commented Feb 3, 2020

@snicket2100 I believe pkgs.git would work here as well, is there any particular reason for gitFull?

@edolstra

This comment has been minimized.

Copy link
Member

edolstra commented Feb 3, 2020

I don't see a reason to add Mercurial. Git is probably fine. What's the impact on the size of the ISO?

@snicket2100

This comment has been minimized.

Copy link
Contributor Author

snicket2100 commented Feb 5, 2020

@danbst No, there wasn't any particular reason to use gitFull. I have changed it to git.

The impact on the size of the ISO is ~ 14MiB.

@snicket2100 snicket2100 force-pushed the snicket2100:git-to-graphical-installation-cd branch from a9847b7 to 7a2f512 Feb 5, 2020
@danbst

This comment has been minimized.

Copy link
Contributor

danbst commented Feb 10, 2020

part of the increased closure size is because of static linking of every Git binary: https://marc.info/?l=git&m=156028332301884&w=2

ncdu 1.14 ~ Use the arrow keys to navigate, press ? for help                                                                                                                                  
--- /nix/store/sgygk97cmx6wz2mr7x83spnkc5j5cg7m-git-2.21.0/libexec/git-core ------------------------------------------------------------------------------------------------------------------
                         /..
    2,9 MiB [##########]  git
    1,7 MiB [#####     ]  git-imap-send
    1,7 MiB [#####     ]  git-remote-http
    1,7 MiB [#####     ]  git-http-push
    1,7 MiB [#####     ]  git-http-fetch
    1,7 MiB [#####     ]  git-fast-import
    1,7 MiB [#####     ]  git-remote-testsvn
    1,6 MiB [#####     ]  git-daemon
    1,6 MiB [#####     ]  git-credential-cache--daemon
    1,6 MiB [#####     ]  git-http-backend
    1,6 MiB [#####     ]  git-credential-store                                                                                                                                                
    1,6 MiB [#####     ]  git-credential-cache
    1,6 MiB [#####     ]  git-sh-i18n--envsubst
    1,6 MiB [#####     ]  git-shell
  160,0 KiB [          ]  git-cvsserver
@danbst danbst merged commit 50a597c into NixOS:master Feb 14, 2020
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Feb 14, 2020

Thanks @danbst

@snicket2100 snicket2100 deleted the snicket2100:git-to-graphical-installation-cd branch Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.