Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: avoid java dependency #79125

Closed
wants to merge 1 commit into from
Closed

chromium: avoid java dependency #79125

wants to merge 1 commit into from

Conversation

@volth
Copy link
Contributor

@volth volth commented Feb 2, 2020

Java dependency results in chromium must be built per each group of machines with different jre (oraclejdk vs openjdk, 8 vs 11, ...).

Also, Guix does it: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/chromium.scm#n472

thanks @danielfullmer (volth#4 (comment))

@volth volth requested review from ivan and colemickens Feb 2, 2020
@flokli
Copy link
Contributor

@flokli flokli commented Feb 2, 2020

Is this about the following feature?

https://chromium.googlesource.com/chromium/src/+show/master/docs/closure_compilation.md

Can we make this configurable, and default to false?

How does it look like with other distros?

@volth
Copy link
Contributor Author

@volth volth commented Feb 2, 2020

@flokli I assume the released versions of chromium (we do not pick up git HEAD here and do not apply any patches on *.js files) have been built somewhere before being released, so the typechecking step had succeeded. Do you have a scenario when setting it to true would bring some value?

How does it look like with other distros?

It is from Guix

@flokli
Copy link
Contributor

@flokli flokli commented Feb 3, 2020

@turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Feb 3, 2020

As far as I know while closure compiler can be used for stuff like type checking which I believe google web toolkit is using it for but the primary usage in wider web ecosystem is for optimization and tree shaking. I would advice to check how it's being used in case of chromium. If optimized files are part of the repo it's fine to exclude it but if there is optional optimization during the build of chromium then excluding it might mean running slower and bigger javascript code (developer tools etc).

Here I found some random reference

@flokli
Copy link
Contributor

@flokli flokli commented Feb 4, 2020

If it's not just used in chromium to "lint" javascript code, but actually remove unused one, I'd prefer keeping it. @volth, can you check?

@volth
Copy link
Contributor Author

@volth volth commented Jun 25, 2020

closure_compile option removed in chromium 85

@volth volth closed this Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.