Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date: init at 2.4.1 #79126

Closed
wants to merge 1 commit into from
Closed

date: init at 2.4.1 #79126

wants to merge 1 commit into from

Conversation

@lovesegfault
Copy link
Contributor

@lovesegfault lovesegfault commented Feb 2, 2020

Motivation for this change

It will be needed for a coming release of Waybar, also seems to be quite popular

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lovesegfault lovesegfault force-pushed the lovesegfault:date-2.4.1 branch from 91b87e4 to 31c9f44 Feb 2, 2020
@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Feb 2, 2020

Closing in favor of #78458

@lovesegfault lovesegfault deleted the lovesegfault:date-2.4.1 branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.