Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moby: remove, merged into linuxkit in 2018 #79135

Merged
merged 1 commit into from Feb 5, 2020

Conversation

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Feb 2, 2020

Motivation for this change

Alias to linuxit, but otherwise drop moby.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Ma27
Copy link
Member

@Ma27 Ma27 commented Feb 4, 2020

@dtzWill when keeping the moby package as alias, shouldn't we add a symlink of bin/moby to bin/linuxkit? :)

@flokli
Copy link
Contributor

@flokli flokli commented Feb 4, 2020

@Ma27 In that case, we'll be afraid removing that wrapper. I propose removing it, maybe adding a release note entry.

Don't alias linuxkit, as linuxkit is not a drop-in replacement.
Instead, throw with an explanation.
(thanks reviewers!)
@dtzWill dtzWill force-pushed the dtzWill:fix/moby-now-linuxkit branch from 377bc45 to 3e83806 Feb 4, 2020
@dtzWill
Copy link
Contributor Author

@dtzWill dtzWill commented Feb 4, 2020

Good points, in turn :). Updated to throw instead. I don't think it's worth the note, unlikely anyone uses and hasn't already moved to linuxkit, no project depended on it under the moby name, etc.

@flokli flokli merged commit cbbb81c into NixOS:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.