Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfsshell: init at 1.1.0 #79142

Closed
wants to merge 1 commit into from
Closed

pfsshell: init at 1.1.0 #79142

wants to merge 1 commit into from

Conversation

@bignaux
Copy link
Contributor

@bignaux bignaux commented Feb 3, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bignaux
Copy link
Contributor Author

@bignaux bignaux commented Feb 3, 2020

@GrahamcOfBorg build pfsshell

Bignaux Ronan
@bignaux bignaux force-pushed the bignaux:pfsshell branch from a3ede13 to 14a4168 Feb 5, 2020
@bignaux bignaux changed the title pfsshell: init at unstable-2020-01-10 pfsshell: init at 1.1.0 Feb 5, 2020
@bignaux
Copy link
Contributor Author

@bignaux bignaux commented Feb 7, 2020

Hello ? have you notice i've fix all your requirement ?

Copy link
Contributor

@Valodim Valodim left a comment

works as expected 👍

};

nativeBuildInputs = [ meson ninja ];
hardeningDisable = [ "format" "fortify" ];

This comment has been minimized.

@Valodim

Valodim Mar 25, 2020
Contributor

perhaps add a comment as to why these are necessary?

@stale
Copy link

@stale stale bot commented Sep 22, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale label Sep 22, 2020
@makefu
Copy link
Contributor

@makefu makefu commented Oct 13, 2020

anything blocking this PR?

@stale stale bot removed the 2.status: stale label Oct 13, 2020
@makefu
Copy link
Contributor

@makefu makefu commented Oct 13, 2020

@GrahamcOfBorg build pfsshell

@makefu makefu requested a review from ajs124 Oct 13, 2020
@Lassulus
Copy link
Contributor

@Lassulus Lassulus commented Oct 13, 2020

there seems to be version 1.1.1 maybe we should update before merging

@bignaux bignaux closed this Oct 13, 2020
@bignaux bignaux deleted the bignaux:pfsshell branch Oct 13, 2020
@makefu makefu mentioned this pull request Oct 21, 2020
7 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.