Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texlive: fix build broken by poppler update #79146

Merged
merged 2 commits into from Feb 3, 2020

Conversation

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Feb 3, 2020

Motivation for this change

Vendored patch, or even patching texlive at all vs. patching poppler
(see mailing list thread and linked issues, arguably poppler bug)
might make this not the best, but it's what I have right now :).

So this is a bit of an issue reporting the breakage :).

The patch included has been working well for me, FWIW.

Check breakage vs fixing with: texlive.bin.core for example.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
dtzWill added 2 commits Jan 21, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 3, 2020

@GrahamcOfBorg build texlive.bin.core

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 3, 2020

since a lot of these are flat out broken, I'm tempted to merge into master immediately

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 3, 2020

I got the error:

/nix/store/jg8wgwfrj7xr5n85xg6hp5ww6ishjhdc-poppler-min-0.84.0-dev/include/poppler/poppler-config.h:142:10: fatal error: cstdio: No such file or directory
  142 | #include <cstdio> // __MINGW_PRINTF_FORMAT is defined in the mingw stdio.h

which seems odd to me, as this is a stdlib c++ header. But I'm not familiar with the poppler build chain. Looks fairly complex.

@jonringer jonringer merged commit d3bef57 into NixOS:master Feb 3, 2020
19 checks passed
19 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
poppler on aarch64-linux Success
Details
poppler on x86_64-darwin Success
Details
poppler on x86_64-linux Success
Details
texlive.bin.core on aarch64-linux Success
Details
texlive.bin.core on x86_64-darwin Success
Details
texlive.bin.core on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.